Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CollectionView Items display issue when Header is resized on iOS - UI-Test #21812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CollectionView Items display issue when Header is resized on iOS - UI-Test #21812

wants to merge 1 commit into from

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Apr 13, 2024

Issues Fixed

Fixes #20538
Fixes #12429

Before After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-13.at.17.21.10.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-13.at.17.17.05.mp4

@kubaflo kubaflo requested a review from a team as a code owner April 13, 2024 15:23
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 13, 2024
PureWeen
PureWeen reviewed Apr 15, 2024
View reviewed changes
src/Controls/src/Core/Handlers/Items/iOS/StructuredItemsViewController.cs Outdated
@@ -46,6 +46,16 @@ protected override void Dispose(bool disposing)
_footerViewFormsElement.MeasureInvalidated -= OnFormsElementMeasureInvalidated;
}

if (_headerUIView is MauiView hv)
{
hv.LayoutChanged += HeaderView_LayoutChanged;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you subscribe to SizeChanged on the header/footer xplat elements?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to do the following:
_headerViewFormsElement.SizeChanged += _headerViewFormsElement_SizeChanged;

_headerViewFormsElement_SizeChanged never triggers

@jsuarezruiz jsuarezruiz added platform/iOS 🍎 area-controls-collectionview CollectionView, CarouselView, IndicatorView labels Apr 15, 2024
@rmarinho
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Jun 12, 2024
@dotnet dotnet deleted a comment from azure-pipelines bot Jun 12, 2024
@dotnet dotnet deleted a comment from azure-pipelines bot Jun 12, 2024
mattleibow
mattleibow reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just wondering about the fact that now we have 2 events that are triggering the layout code when the first did not work. Is there a reason for both?

src/Controls/src/Core/Handlers/Items/iOS/StructuredItemsViewController.cs Outdated
Comment on lines 49 to 52
if (_headerUIView is MauiView hv)
{
hv.LayoutChanged -= HeaderViewLayoutChanged;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are now watching the actual method that is doing layout, do we still need the original _footerViewFormsElement.MeasureInvalidated? The code seems to end up calling the same HandleFormsElementMeasureInvalidated method.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IS grabbing the element for footer and header not the all view right? some still need for each one .

src/Core/src/Platform/iOS/MauiView.cs Outdated
@@ -134,6 +134,7 @@ public override void LayoutSubviews()
}

CrossPlatformArrange(bounds);
OnLayoutChanged();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be renamed to match the method. Also, no need to have the method, just invoke the event directly. Maybe use a name of ArrangingSubviews or even just OnLayoutSubviews since it is internal. I see MovedToWindow got away with the same name because it was an explicit interface member.

Copy link
Contributor Author

@kubaflo kubaflo Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to invoke the event directly

PureWeen
PureWeen requested changes Aug 3, 2024
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revisit if this is needed once we test on net9 with CollectionViewHandler2 and once we merge this PR #23052

@rmarinho
Copy link
Member

/rebase

@rmarinho
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

@kubaflo Could you rebase and fix the conflicts? Thanks in advance.

@kubaflo
Copy link
Contributor Author

kubaflo commented Oct 31, 2024 •
edited
Loading

@jsuarezruiz Rui has cherry-picked commits from this PR to this PR: #25157

But I think we can keep the UT test in this PR. What do you think? If, so then we will need to change the iOS screenshot, because it will probably fail because of dimensions

@kubaflo kubaflo changed the title CollectionView Items display issue when Header is resized on iOS - Fix CollectionView Items display issue when Header is resized on iOS - UI-Test Oct 31, 2024
@kubaflo
Copy link
Contributor Author

kubaflo commented Nov 15, 2024

We should revisit if this is needed once we test on net9 with CollectionViewHandler2 and once we merge this PR #23052

@PureWeen you were right!
But I think we can include the UI test from this PR. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

@rmarinho rmarinho rmarinho left review comments

@mattleibow mattleibow mattleibow left review comments

@PureWeen PureWeen PureWeen requested changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution platform/iOS 🍎
Projects
None yet
Milestone
No milestone
5 participants
@kubaflo @rmarinho @jsuarezruiz @mattleibow @PureWeen