Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_annotation does not check if the time stamp (left/right) does already exist #20

Open
thomaskisler opened this issue Jun 3, 2019 · 4 comments

Comments

@thomaskisler
Copy link
Contributor

I would expect if I add an annotation that first, the add_annotation(...) method would check if the timestamp does already exist in a linked tier. And if so, it would use the already existing time stamp, before adding a new one. However, that is not what I see. Is this on purpose?

I am using pympi 1.69

@dopefishh
Copy link
Owner

This is not on purpose and would be a perfect enhancement of the library

@dopefishh
Copy link
Owner

This could be implemented by patching the generate_ts_id function.

@dopefishh
Copy link
Owner

I've reverted the MR because not all functions take this property into mind and therefore some functionality behaves off due to reusing timeslots.

@dopefishh dopefishh reopened this Feb 3, 2021
@Cogitarian
Copy link

Adding new annotations works only for nonadjacent annotations, that is when the onset of the annotation I add does not equal to the ending of a previous one. Suppose I have two annotations with timestamps: 1000-2000 and 2000-3000. I can't add new annotation starting at 3000 and I can't change the first annotation with re moving it and adding a new one with a new label. Is there any other way to remove or change annotation which have the same ending as the next one? I hope it is clear ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants