Rework of HTML publisher. #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esign. Renamed it to doorstop.
…nately they do not help with coverage.
…ait for bottle to be updated.
…overage change compared to 'develop' branch.
jacebrowning
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated both the HTML-publisher and the
doorstop-serverto user a new layout with a top menu instead of the sidebar, which fixes #327. By upgrading to newer version of bootstrap, the dependency of jquery was removed.The change also includes the possibility for the users to create really custom HTML exports as the
.tplfiles are now included in the publishing process so that a user can included custom Bottle-template files as well.Installed a local copy of MathJax so that offline installations work properly.
I also included support for the document attributes that was included for LaTeX publishing, so that the HTML publish also has this information, which fixes #26.
A few bugs that were not yet reported were also fixed, mainly a problem with the #615 PR which had introduced an error when publishing a single document that I did not catch earlier.
Further testing also resulted in reworking the Markdown publishing since links between items where broken, which fixes #378. Since publishing now is separated it was easy to fix without affecting the other formats. This also lead to fixing #469 since the extra space caused havoc to the links.
This PR might also fix #515. After it's been published it would be nice with some feedback on if this is good enough for that issue.
Some dependencies have also been updated and a lot of new test cases to get better coverage on the changed parts of the code.
Also added a couple of new dev-dependencies so that the API server calls can be tested and it is now possible to run
make test-coverto get immediate feedback on if the changed code is covered by tests of not (instead of waiting for the CI-job to run).