Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RiotApi v4 #24

Closed
regiszanandrea opened this issue Nov 29, 2018 · 13 comments
Closed

Support for RiotApi v4 #24

regiszanandrea opened this issue Nov 29, 2018 · 13 comments
Assignees
Labels
implementation-outdated Current implementation of this library is outdated and needs an update.

Comments

@regiszanandrea
Copy link

Is your feature request related to a problem? Please describe.
The Riot Developers announced that v3 API will be deprecated soon.

Describe the solution you'd like
Today, they made available the endpoints from the new API version, v4. In the link below, there are the endpoints that needed to be implemented:

https://developer.riotgames.com/api-methods/

@boraguler
Copy link

I'm waiting for it too, can help you with it Daniel if needed.

@dolejska-daniel dolejska-daniel self-assigned this Nov 29, 2018
@dolejska-daniel dolejska-daniel added the implementation-outdated Current implementation of this library is outdated and needs an update. label Nov 29, 2018
@dolejska-daniel
Copy link
Owner

Hi guys,

there will be only minor adjustments to match v4 endpoint call changes. Thought there would be things I'd be grateful to get helped with -- I'll let you know soon 😆.

dolejska-daniel added a commit that referenced this issue Nov 29, 2018
@dolejska-daniel
Copy link
Owner

dolejska-daniel commented Nov 29, 2018

So... I know that noone likes to write tests (#26) - BUT it needs to be done. And if you could help, that would be awesome!

There are also some things to be done to bridge StaticData calls from RiotAPI to DataDragonAPI (#25). But these are not that important.

@dolejska-daniel
Copy link
Owner

In the end, I wll manage to fix the tests by myself.

#25 should be priority now.

@dolejska-daniel
Copy link
Owner

@regiszanandrea, @boraguler library should support v4 endpoints now! Please test it 😸. Note that Champion Mastery endpoint is not working correctly yet (Serivce unavailable).

Also, the tests should be kind of working again. But definitely are not complete. So any additions are welcome.

@regiszanandrea
Copy link
Author

@dolejska-daniel Working as Designed.

Thank you so much ❤️

@regiszanandrea
Copy link
Author

Hey @dolejska-daniel, I'll create a new issue for Tournament V4 Support, it's ok?

@dolejska-daniel
Copy link
Owner

@regiszanandrea sure is! Didn't hear anything about Tournament v4 😮

@regiszanandrea
Copy link
Author

@dolejska-daniel I think the only thing that will change is in the tournament code creation, passing the encrypted summonerId

@dolejska-daniel
Copy link
Owner

Hey guys! Champion Mastery v4 and Tournament Stub v4 are up and running on a58847c 😼.

@regiszanandrea
Copy link
Author

@dolejska-daniel Tournament v4 is available :)

@dolejska-daniel
Copy link
Owner

All v4 endpoints should be working on v3.0.0-alpha. Static data through RiotAPI still not implemented.

@regiszanandrea
Copy link
Author

regiszanandrea commented Dec 13, 2018

@dolejska-daniel Love you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation-outdated Current implementation of this library is outdated and needs an update.
Projects
None yet
Development

No branches or pull requests

3 participants