Unable to instantiate Schema objects without deprecations

[xabbuh]

Bug Report

Q	A
Version	4.3.x
Previous Version if the bug is a regression

Summary

It looks like with the changes from #6734 it would currently not be possible with Doctrine DBAL 4.3 to create Schema instances without triggering deprecations. I talked with @greg0ire about this on Slack and he suggested that this might be an oversight and switching to triggerIfCalledFromOutside() when issuing the deprecation or adding an exception there if $this is an instance of Schema could be possible solutions.

Current behavior

Expected behavior

Constructing Schema objects should be possible without deprecations.

How to reproduce

see https://github.com/symfony/symfony/actions/runs/12953164049/job/36132194682#step:9:1211

[greg0ire]

@morozov can you please look into this?

[morozov]

We probably need to backport this method which I introduced only during the merge up in #6735:

dbal/src/Schema/Schema.php

Lines 130 to 138 in c7877f3

	/**
	* The object representation of the name isn't used because {@see Schema} is not an {@see AbstractAsset}.
	*
	* This method implements the abstract method in the parent class and will be removed once {@see Schema} stops
	* extending {@see AbstractAsset}.
	*/
	protected function setName(?Name $name): void
	{
	}

[morozov]

@xabbuh thanks for pointing out the regression. Unlike API consumers (e.g. Symfony) which indent to stay deprecation-free, the library itself must execute some deprecated code paths for backward compatibility (not in this case, though). Because of that, it is hard to imagine a way for us to make sure that the deprecation notices are only triggered when they are supposed to.

It is really great that there's a 3rd-party test suite that can find such regressions. What would be the easiest way to run this test suite locally to confirm that no similar regressions are introduced in the future?

[xabbuh]

@morozov Twig runs Drupal tests. Maybe you could take inspiration from it: https://github.com/twigphp/Twig/blob/3.x/tests/drupal_test.sh