Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running tests when SEND_EMAILS is set to true in config sends emails #37

Open
martinzlocha opened this issue Aug 26, 2018 · 0 comments
Open

Comments

@martinzlocha
Copy link
Member

Detailed Description

Make sure that tests don't send emails, this should be mocked out.

Context

Currently you need to check that you don't have SEND_EMAILS set to true before sending emails. This should be avoided if at all possible.

Possible Implementation

Either mocking or test.sh should set a temporary environment variable which should be checked and if set then emails shouldn't be sent. First method is preferred but either works.

Your Environment

  • Version used:
  • Environment name and version (e.g. Chrome 39, node.js 5.4):
  • Operating System and version (desktop or mobile):
  • Link to your project:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant