Metadata flagged partials #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 9, 2016 18:46
[Fixes #31] Instead of suplimenting the query array in fuzzyFindOne(), I opted for a localised solution: calling findOne() directly with additional queries. These additional queries are only called should fuzzyFindOne() return null. And indeed they shortcircuit to give the best performance. Tests and the plugin's README.md is also changed to reflect the solution.
[Fixes #31] Instead of suplimenting the query array in fuzzyFindOne(), I opted for a localised solution: calling findOne() directly with additional queries. These additional queries are only called should fuzzyFindOne() return null. And indeed they shortcircuit to give the best performance. Tests and the plugin's README.md is also changed to reflect the solution.
…hkieffer/docpad-plugin-partials into metadata-flagged-partials
|
I have become too preoccupied by other things to review, merge, and release this PR. However, you should have received an invite a while ago to join the DocPad Extras Team, which will give you write access to this repository, so you can merge in the PR, and become one of the maintainers of this repository. For an orientation, or if you need any assistance following the semi-automatic release process from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixes #31]
Instead of supplementing the query array in
fuzzyFindOne(), I opted for a localised solution: callingfindOne()directly with additional queries.These additional queries are only called should
fuzzyFindOne()returnnull. And indeed they short-circuit to give the best performance.Tests and the plugin's
README.mdis also changed to reflect the solution.