-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.30.0 update breaks VScode devcontainer auto port forwarding #7276
Comments
I tried the same on another machine with docker 4.29.0 and this works as expected. |
cc @djs55 |
This happens when pairing docker desktop 4.30.0 with vscode devcontainers on Windows too. |
Docker Desktop on window updated to v4.30.0 this morning, and can confirm that port forwarding is no longer working Update: a downgrade to 4.29.0 has vscode devcontainer port forwarding working again. After rebuilding the containers. |
Downgrading to 4.29.0 or 4.27.2 quickly causes docker desktop to automatically exit, uninstall and install the latest 4.30.0 even with "Automatically check for updates" and "Always download updates" unchecked. |
We are facing the same with both docker desktop on Windows and Linux. Downgrading to 4.29.0 fixed it. |
Facing the same issues on Docker for Windows latest version 4.31.0 |
I can confirm that 4.31.0 on Mac has this issue. Rolling back to 4.29.0 is a workaround. |
Another workaround is adding the following to the vite config:
|
Same here, on MacOs, can confirm 4.31.0 same issue, downgrade to 4.29.0 did the trick as a workaround |
I tried it with 4.32.0 on MacOS and get the same issue, the port forwarding does not work. |
Not related to Mac, but I faced the same issue on Docker for Windows 4.32.0. |
Same issue here, Mac, version 4.32.0 and 4.31.1 |
Or angular: ng serve --host 127.0.0.1 Version 4.32.0 (157355). Remark: the open port is not displayed in Docker Desktop (Mac) in the container list, but it works... |
The issue occurs in Windows 22631.4037 with Docker version 4.33.1. I need to rollback to Docker ver. 4.29.0 |
Worked for me in Manjaro 24.0.7 and Docker version 27.1.1, build 63125853e3 Also when I do |
It's been about six months and this problem remains unfixed without a workaround. Clearly, Docker doesn't think it's their problem. Is it actually a VS Code issue? Or something that needs updating in dev container configurations? Where do we go from here? If someone hasn't done so, open an issue with VS Code and see if we can get some more traction. |
Can confirm that accessing Angular app in devcontainer works only when --host 127.0.0.1 is specified. Docker 4.34 Also I don't think this issue has correct name. Auto port forwarding works ok, it's just that now apps binds to different host I guess. |
- see issue "4.30.0 update breaks VScode devcontainer auto port forwarding" (docker/for-mac#7276)
Can confirm that switching from |
I'm not using Docker Desktop but docker-ce directly in WSL. This doesn't seem to be an issue with Docker Desktop, but with the Docker Engine itself. I tested different versions to pin down when this issue was introduced. The issue first appeared in 26.0.2, and is present in all versions up to the current version (27.0.5). The last unaffected release is 26.0.1. Note that 26.0.0 and 26.0.1 are affected by CVE-2024-32473, so you might want to downgrade to 25.0.5 instead if this vulnerability is relevant to you. Specifically, I downgraded to the following package on my Ubuntu 22.04 WSL installation: sudo apt install docker-ce=5:26.0.1-1~ubuntu.22.04~jammy
sudo apt-mark hold docker-ce The issue has already been reported to vscode-remote: microsoft/vscode-remote-release#7029 EDIT:
Workarounds:
|
Starting with v26.0 Docker Engine always inject Looking at VSCode logs in
To be clear, we're not going to change the Engine behavior because: 1. it's perfectly fine, at least if no software make wrong assumptions; 2. reverting back to what we had prior to v26 would break people that now make the assumption that For now, you need to either disable IPv6 within your container with I'd recommend that whoever is facing this issue should report it to the VSCode team. |
One of the vite maintainer went ahead and added a section to vite's troubleshooting guide stating what the issue is and how to work around it. See: vitejs/vite#19303 Since the issue isn't on our side, I'll close this ticket but feel free to continue the conversation. |
Description
4.30.0 breaks auto port forwarding in VScode dev containers.
With 4.29.0 (or whatever was before 4.30.0/today's update) I could start my dev container and run
npm run dev
and access my website viahttp://localhost:5173
in the browser. That does not work anymore.I can make it work by doing npm run dev -- --host (but I did not have to do that before today's update and VScode did not release any updates today for this).
Reproduce
Dev Containers: Rebuild Container
npm i
inside the containerrpm run dev
inside the containerhttp://localhost:5173
in your browserExpected behavior
A simple react website should load.
docker version
Client: Cloud integration: v1.0.35+desktop.13 Version: 26.1.1 API version: 1.45 Go version: go1.21.9 Git commit: 4cf5afa Built: Tue Apr 30 11:44:56 2024 OS/Arch: darwin/arm64 Context: desktop-linux Server: Docker Desktop 4.30.0 (149282) Engine: Version: 26.1.1 API version: 1.45 (minimum version 1.24) Go version: go1.21.9 Git commit: ac2de55 Built: Tue Apr 30 11:48:04 2024 OS/Arch: linux/arm64 Experimental: false containerd: Version: 1.6.31 GitCommit: e377cd56a71523140ca6ae87e30244719194a521 runc: Version: 1.1.12 GitCommit: v1.1.12-0-g51d5e94 docker-init: Version: 0.19.0 GitCommit: de40ad0
docker info
Diagnostics ID
BC1CB2B2-B69E-4396-8D7A-B7A17288F241/20240510045331
Additional Info
No response
The text was updated successfully, but these errors were encountered: