Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: DNN 10 Theme - Update color system to incorporate --dnn-color-variation-opacity and --dnn-color-surface-* and --dnn-color-*-<r, g, b> #6139

Open
4 tasks done
david-poindexter opened this issue Sep 27, 2024 · 0 comments

Comments

@david-poindexter
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description of problem

Updates have now been made to the new DNN color system and those changes need to be incorporated into the new DNN 10 theme. The following CSS variables have now been added:

  • --dnn-color-variation-opacity (new CSS variable that can be used to handle opacity calculations)
  • --dnn-color-surface-* (new set of CSS variables to handle surfaces like "cards" or other layers on the z axis)
  • --dnn-color-*-r
  • --dnn-color-*-g
  • --dnn-color-*-b

The RGB numeric values are already there, but they were only there for the base colors. Now RGB values will be available for all base colors plus their light, dark, contrast variations.

Before

    --dnn-color-primary
    --dnn-color-primary-light
    --dnn-color-primary-dark
    --dnn-color-primary-contrast
    --dnn-color-primary-r
    --dnn-color-primary-g
    --dnn-color-primary-b

After

    --dnn-color-primary
    --dnn-color-primary-r
    --dnn-color-primary-g
    --dnn-color-primary-b
    --dnn-color-primary-light
    --dnn-color-primary-light-r
    --dnn-color-primary-light-g
    --dnn-color-primary-light-b
    --dnn-color-primary-dark
    --dnn-color-primary-dark-r
    --dnn-color-primary-dark-g
    --dnn-color-primary-dark-b
    --dnn-color-primary-contrast
    --dnn-color-primary-contrast-r
    --dnn-color-primary-contrast-g
    --dnn-color-primary-contrast-b

Description of solution

Add new CSS variables listed above.

Description of alternatives considered

Many were discussed, but this was the consensus approach between several DNN community members during a live co-coding session on Sep 27, 2024.

Anything else?

No response

Do you be plan to contribute code for this enhancement?

  • Yes

Would you be interested in sponsoring this enhancement?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant