Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBS unit tests contradict code logic #647

Open
vkuznet opened this issue Feb 18, 2021 · 3 comments
Open

DBS unit tests contradict code logic #647

vkuznet opened this issue Feb 18, 2021 · 3 comments

Comments

@vkuznet
Copy link
Contributor

vkuznet commented Feb 18, 2021

Yuyi, I found that the following unit tests contradict DBS code logic: test03300t, test033r, test033s, test034h, test034o. In all of them except test034h, the input parameter contains run list in a form run1-run2 (it is a range of runs but any range is a list). In DBS codebase it is prohibited here. I test034h (marked as test34h) you pass run_num=1 and code prohibit if lumis and LFN are not provided, see code here.

I suggest that you properly adjust unit tests to cover this use-cases.

@yuyiguo
Copy link
Member

yuyiguo commented Feb 24, 2021

Valentin,
I do not understand the future of DBS currently. So I will work on the essential stuff for DBS only. Can we hold your requests on DBS after we talk with Kevin? I don't see any urgent issues on DBS except for the prod and crab move out from cmsweb to cmsweb-prod. I will follow up that with the email thread. If you want to call Kevin for a meeting on DBS, please feel free to do so,
Thanks,
Yuyi

@vkuznet
Copy link
Contributor Author

vkuznet commented Feb 24, 2021

Yuyi, I do not ask for immediate actions, but I also don't want to forget found issues. Therefore I document them in tickets. I fully agree that we first should decide how to treat DBS in next data rounds and then work on open tickets (if necessary).

@yuyiguo
Copy link
Member

yuyiguo commented Feb 24, 2021

Great, We are on the same page. I don't want to let you feel that I ignore your requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants