Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for including comments in Zendesk source #579

Open
stevewb1993 opened this issue Nov 1, 2024 · 1 comment
Open

Add support for including comments in Zendesk source #579

stevewb1993 opened this issue Nov 1, 2024 · 1 comment

Comments

@stevewb1993
Copy link

stevewb1993 commented Nov 1, 2024

The default zendesk source does not (as far as I can tell) include comments which are added to tickets. It's quite easy for users of DLT to update the existing source code to include it if they read how to on the Zendesk documentation, but I think it would make it easier for DLT users if this was included as an option in the existing code.

Per my discussion on slack here, I'm raising an issue for this and will raise a PR shortly to implement this.

Are you a dlt user?
Yes, I'm already a dlt user.

Proposed solution
Per the zendesk documentation, use sideloading to include comments. This means adding "include": "comment_events" in the parameters to the /api/v2/incremental/ticket_events.json endpoint.
I'm open to suggestions on whether this should be included by default or not. My initial thought was to add a flag here for whether to include ticket comments, with a default value of False.

Apologies if I've raised the wrong type of issue for this. I wasn't sure if this counted as extending a source.

@stevewb1993
Copy link
Author

draft pr for discussion here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

No branches or pull requests

1 participant