Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download link broken in documentation #59

Open
joeshannon opened this issue Sep 1, 2022 · 1 comment
Open

Download link broken in documentation #59

joeshannon opened this issue Sep 1, 2022 · 1 comment

Comments

@joeshannon
Copy link

The link to download the script here is broken. The link in question is https://github.com/dls-controls/dev-c7/releases/download/main/run-dev-c7.sh

Looking at the docs source it is parameterised by the version. This will work for tags which have a corresponding GitHub release but for the main docs build it fails as there is no "main" release.

It could be switched to use "latest" i.e. https://github.com/dls-controls/dev-c7/releases/latest/download/run-dev-c7.sh or to download the raw file on main which would be https://raw.githubusercontent.com/dls-controls/dev-c7/main/run-dev-c7.sh.

@gilesknap
Copy link
Contributor

Sorry I seem to have missed this issue for 5 weeks!

What happens is the CI patches the file with the current version and adds it as a release asset.
The comments in the docs above are supposed to make you use the correct version of the docs

IMPORTANT: before doing the next steps go to ‘Other Versions’ at the bottom of the left side-bar and select the version you want. The latest version is recommended

This is a bit crap really and is all to do with trying to tie the launch script and the version of the container together.

Maybe we should just go with latest as you say. Its possible to request a different version of the container from the run script args but the problem with latest is you have no sight of what you are currently running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants