Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework with mir #271

Closed
wants to merge 3 commits into from
Closed

rework with mir #271

wants to merge 3 commits into from

Conversation

9il
Copy link
Member

@9il 9il commented Jul 6, 2021

  • replace real with double to match other implementations: excess precision is bad when one need precise serialisation, fixes double is a better then real #270
  • use mir to/from string for floating point numbers, fixes Loss of precision when representing reals #249
  • replace SysTime with Timestamp, arbitrary timestamp precision is supported now. For example, one can de/serialise Date without additional time. master can serialise only full precision timestamps.
  • added mir engine de/serialisation support for Node

@Herringway
Copy link
Member

I'd rather not introduce new dependencies to DYAML.

@9il
Copy link
Member Author

9il commented Jul 6, 2021

We need this changes or a fork. I expect that the fork will dominate after a while because of Symmetry.

@Herringway
Copy link
Member

I cannot accept a dependency as large as mir-algorithm. This is not something I can maintain alone. There are also a large number of seemingly-irrelevant changes, such as the inclusion of an output.yaml, a submodule that appears to be unused, and private symbols being made public.

Threatening to fork will not address any of these issues. Competition is welcome.

@9il 9il closed this Jul 6, 2021
@9il
Copy link
Member Author

9il commented Jul 6, 2021

I hope you will change you mind. You wouldn't be alone to maintain it I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

double is a better then real Loss of precision when representing reals
2 participants