Skip to content
This repository has been archived by the owner on Jan 22, 2018. It is now read-only.

Resubscribing doesn't properly load data #14

Open
dbismut opened this issue Jan 18, 2016 · 1 comment
Open

Resubscribing doesn't properly load data #14

dbismut opened this issue Jan 18, 2016 · 1 comment

Comments

@dbismut
Copy link

dbismut commented Jan 18, 2016

Hey @djhi - your project is the best thing that happened to me in understanding how Redux works with Meteor in a clean way.

However, I've changed some things in the way you handle subscriptions in the MeteorSubscription middleware.

  1. I think there is a bug at line 4 where handles and computations are defined as arrays [] while they should be objects {}.
  2. Stopping subscriptions when they already exist doesn't work for me: for example, when I logout from my app, and then re-login, the new subscription never gets ready() and I'm stuck at loading (possibly because of the way I handle auth, I don't know). My way of making it work at the moment is to skip the new subscription, but I guess I might run into issues.
@djhi
Copy link
Owner

djhi commented Jan 18, 2016

Good catch, thx for reporting this. I'll take a look asap

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants