Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUES with TopCat #197

Closed
2 tasks
agy-why opened this issue Aug 7, 2023 · 2 comments · Fixed by #205
Closed
2 tasks

ISSUES with TopCat #197

agy-why opened this issue Aug 7, 2023 · 2 comments · Fixed by #205

Comments

@agy-why
Copy link
Member

agy-why commented Aug 7, 2023

Hi Yori,

sorry about the slow response, I've just got back from a couple
of weeks on holiday.

The error about an unclosed link tag relates to the examples document
at https://gaia.aip.de/tap/examples.
Although it doesn't explicitly say this in the TAP 1.1 specification,
this document must be XHTML, i.e. well-formed XML (unlike HTML,
close tags may not be omitted); this is written in sec 2.3 of DALI 1.1,
to which the TAP examples document must conform.
There are some unclosed elements in that document:

% curl -s https://gaia.aip.de/tap/examples | xmllint -noout -
-:33: parser error : Opening and ending tag mismatch: link line 30 and head

^ -:1551: parser error : Opening and ending tag mismatch: link line 30 and html ^ -:1552: parser error : EndTag: 'which are causing the problem. That means that the machine-readable
examples are not visible from topcat, though it doesn't itself break
other things.

However, this error:

WARNING: Row count for TAP_SCHEMA.columns failed: java.io.IOException:
Unexpected column count: 0 != 1

is reporting something different. The problem here is that the
following query:

SELECT COUNT(*) AS nrow FROM TAP_SCHEMA.columns

which topcat does as part of the metadata acquisition returns a
table with no columns. Looking at it
(REQUEST=doQuery&LANG=ADQL&QUERY=SELECT+COUNT%28*%29+AS+nrow+FROM+TAP_SCHEMA.columns)
the problem seems to be that there is a missing FIELD element in the
output.

If you run topcat with the flags "-verbose -verbose" you can see what
it's doing in a way that may help you to diagnose problems.

Even better, run the stilts taplint command on your service
(topcat -stilts taplint tapurl=https://gaia.aip.de/tap)
which will show up these and other compliance issues in the service,
with hopefully somewhat explanatory explanations - see
http://www.starlink.ac.uk/stilts/sun256/taplint.html

Mark

TODO

  • solve issue with example page
  • solve issue with TAP_SCHEMA
@agy-why
Copy link
Member Author

agy-why commented Aug 9, 2023

Typically this returns an unvalid VOTable:
https://gaia.aip.de/tap/sync?REQUEST=doQuery&LANG=ADQL&QUERY=SELECT+COUNT%28*%29+AS+nrow+FROM+TAP_SCHEMA.columns

Where FIELD (column info) are missing.

With async all is fine.

@kimakan
Copy link
Contributor

kimakan commented Aug 9, 2023

Regarding the unclosed link tag, it seems that the django-compressor removes the closing tags.

{% compress css %}
<link rel="stylesheet" type="text/x-scss" href="{% static 'tap/css/examples.scss' %}" />
{% endcompress css %}

results in

<link rel="stylesheet" href="/static/CACHE/css/output.53dea850c36b.css" type="text/css">

It's also the case in the header

{% compress css %}
<link rel="stylesheet" type="text/x-scss" href="{% static 'core/css/base.scss' %}" />
<link rel="stylesheet" type="text/x-scss" href="{% static 'core/css/fonts.scss' %}" />
<link rel="stylesheet" type="text/x-scss" href="{% static 'core/css/style.scss' %}" />
<link rel="stylesheet" type="text/x-scss" href="{% static 'core/css/codehilite.scss' %}" />
{% endcompress %}

is compressed to

<link rel="stylesheet" href="/static/CACHE/css/output.caa75e54c6ac.css" type="text/css">

@agy-why agy-why modified the milestones: Next version, MiniRelease Aug 25, 2023
@agy-why agy-why linked a pull request Aug 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants