Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footer issue and ensure it stays at the bottom of the webpage #153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lakshyagrg23
Copy link

@lakshyagrg23 lakshyagrg23 commented Oct 22, 2024

πŸ› οΈ Fixes Issue

Closes #147

πŸ‘¨β€πŸ’» Description

  • This PR fixes the issue where the footer was not getting rendered right at the bottom of all the web pages, except the homepage, and was leaving some blank space at the bottom.
  • Minor changes in index.css have been made where the min-height of main and footer have been adjusted accordingly.
  • It successfully resolved the issue and makes the footer appear at the bottom as it should be.

πŸ“„ Type of Change

  • [βœ…] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots/GIFs

Screenshot of Expense page
Screenshot of Todo page

βœ… Checklist

  • [βœ…] I am a participant of GSSoC-ext.
  • [βœ…] I have followed the contribution guidelines of this project.
  • [βœ…] I have viewed deployment of my code.
  • [βœ…] My changes generate no new warnings.
  • I have added documentation to explain my changes.

🀝 GSSoC Participation

  • [βœ…] This PR is submitted under the GSSoC program.
  • I have taken prior approval for this feature/fix.

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
my-calendar-app βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 22, 2024 6:27pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The Footer on Add Expenses and Add Todo pages is not correctly placed at the bottom
1 participant