Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stereo chorus #46

Open
mmontag opened this issue Jan 31, 2023 · 0 comments
Open

Stereo chorus #46

mmontag opened this issue Jan 31, 2023 · 0 comments

Comments

@mmontag
Copy link

mmontag commented Jan 31, 2023

I noticed that fluidlite is using an older, mono implementation of the chorus effect:

/* Add the chorus sum d_out to output */
left_out[sample_index] += d_out;
right_out[sample_index] += d_out;

It would be nice to update this to the latest upstream chorus implementation, which is stereo:
https://github.com/FluidSynth/fluidsynth/blob/master/src/rvoice/fluid_chorus.c

In my opinion, poor chorus implementations have been a major sore spot of General MIDI over the years. (In my project, I had chorus completely disabled for a long time.) It could really sound like a rich Juno 106 chorus for little to no extra cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant