Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use target_include_directories to specify public header path #398

Closed
ChrisThrasher opened this issue Aug 8, 2024 · 1 comment
Closed

Comments

@ChrisThrasher
Copy link

include_directories(${PROJECT_SOURCE_DIR}/include)

This use of include_directories means that those who link to the discord-rpc target will not inherit the include paths required to use this target. An easy fix is to change this to a target_include_directories call with PUBLIC visibility so those linking to discord-rpc don't need to manually specify the include paths.

@p0358
Copy link

p0358 commented Oct 14, 2024

This was PR'd into our fork of this library: harmonytf#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants