Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserWarning: Duplicate name job.py and worker.py #622

Open
erikdubbelboer opened this issue Jun 12, 2015 · 0 comments
Open

UserWarning: Duplicate name job.py and worker.py #622

erikdubbelboer opened this issue Jun 12, 2015 · 0 comments

Comments

@erikdubbelboer
Copy link
Contributor

When starting a job you always get the following two warnings:

/usr/local/lib/python2.7/dist-packages/disco/fileutils.py:141: UserWarning: Duplicate name: 'usr/local/lib/python2.7/dist-packages/disco/job.py'
  self.write(file, file)
/usr/local/lib/python2.7/dist-packages/disco/fileutils.py:141: UserWarning: Duplicate name: 'usr/local/lib/python2.7/dist-packages/disco/worker/classic/worker.py'
  self.write(file, file)

These are cause by

disco/lib/disco/worker/__init__.py

Lines 242 to 243 in 83874d9

jobzip.writesource(job)
jobzip.writesource(self)

I was wondering why these two lines are there seeing as discopath already contains these?
I removed the lines and ran make test which didn't result in any errors.
pooya added a commit to pooya/disco that referenced this issue Aug 15, 2015
@pooya
remove unnecessary files added to the worker zipfile
5b57ade 
fix issue discoproject#622
Thanks to @erikdubbelboer.

The newer versions of python print a warning message for duplicate files.
The file finder is able to add these files and add them to the zipfile.
@pooya pooya mentioned this issue Aug 15, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erikdubbelboer