Project: return success after removing ID

[lionello]

When a project is gone from DO, a refresh fails because the project cannot be found. The code detects the 404 but still returns an error, so the refresh fails, instead of saving the updated state.

Here's a log (from Pulumi):

[2025-01-17 03:01:35]  ~  digitalocean:index:Project project refreshing (0s) error:   sdk-v2/provider2.go:457: sdk.helper_schema: Error reading Project: GET https://api.digitalocean.com/v2/projects/7242f1c8-65fb-46bd-93e2-63b263ddd15e: 404 (request "f81512c7-d34c-4c04-ab6b-aedbad9cead9") project not found: [email protected]

After erasing the resource ID, the code falls through to the error, instead of returning nil (which is also the behavior of many other resources in the 404 case).

[andrewsomething]

Great catch! Thanks @lionello! 🙏

[lionello]

@andrewsomething Thanks!

By the way, there might be more like these. Here's another one:

terraform-provider-digitalocean/digitalocean/cdn/resource_cdn.go

Line 203 in 172b96c

d.SetId("")

[kumavis]

requesting release that includes this fix