Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App can't be be normaly sopped if source wait to reload #22

Open
yellow-sky opened this issue Dec 16, 2020 · 1 comment
Open

App can't be be normaly sopped if source wait to reload #22

yellow-sky opened this issue Dec 16, 2020 · 1 comment

Comments

@yellow-sky
Copy link

  1. Source can't connect to kafka\other resource - executor wait 10 sedonds (
    time.Sleep(10 * time.Second)
    )
  2. During this period of time, a shutdown message is received by app (
    func (e *Executor) Shutdown() (done chan struct{}) {
    )
  3. Executor try to shutdown source, but old instance (
    err := e.source.Shutdown()
    )
  4. Executor continues to execute an infinite loop ( )
  5. New source instance doesn't know anything about studown signal
  6. Go to step 4
    =>
    App does not respond to system shutdown signals
@jnadler
Copy link
Contributor

jnadler commented Dec 16, 2020

Thanks for the bug report @yellow-sky - I can see how this is a problem if a firebolt app starts while kafka is unavailable. I'll work on fixing this when I can, or if you need it fixed quickly we'd be happy to consider a pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants