Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom screen flow with standard declarative state-based react #7

Open
jchartrand opened this issue Feb 2, 2024 · 0 comments

Comments

@jchartrand
Copy link
Contributor

Quite a bit of fairly complicated custom code is used to move through screens in the dashboard, seemingly using forward refs to show/hide screens, e.g.,

https://github.com/digitalcredentials/admin-dashboard/blob/main/services/payload/src/components/batch/RenderBatchFlowFields.tsx

The code seems intended to allow UI based configuration of screens at some point in time, but at the cost of significant extra complexity.

Given that there are no plans to add UI-based config, and since there are currently relatively few screens, it might be clearer to replace that code with standard declarative react - showing/hiding screens based on state variables.

A more conventional react-like model might make it easier for adopters to understand how to modify to suit their needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Admin Dashboard Backlog
Development

No branches or pull requests

2 participants