Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all statuses are checked (do not short-circuit on errors / failures) #6

Open
dlongley opened this issue Mar 20, 2024 · 0 comments

Comments

@dlongley
Copy link
Member

We check all matching statuses in parallel (which is good) here: https://github.com/digitalbazaar/vc-bitstring-status-list/blob/main/lib/index.js#L308 ... however, we need to ensure that all the checks happen and we don't shortcircuit all of them if just one fails. This can be done either by using Promise.allSettled and writing some mapping code on the results, or probably more simply by making _checkStatus wrap everything internally in a try/catch that catches any error and maps it to {verified: false, error}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant