Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor _suiteForType helper. #61

Open
mattcollier opened this issue May 4, 2021 · 0 comments
Open

Refactor _suiteForType helper. #61

mattcollier opened this issue May 4, 2021 · 0 comments

Comments

@mattcollier
Copy link
Contributor

I think we're playing a little fast and loose with this API (maybe you pass a doc, maybe you pass some options, if the thing you pass isn't defined its treated the same as no type being passed ... and so on). I could see someone getting tripped up on this in the future. So we might want it to be a little cleaner, but won't hold up the PR for it.

Originally posted by @dlongley in #60 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant