Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedings Report: message in Tray/Direct Summaries #57

Open
wpgoble opened this issue Jan 11, 2024 · 5 comments
Open

Seedings Report: message in Tray/Direct Summaries #57

wpgoble opened this issue Jan 11, 2024 · 5 comments
Labels
UI/UX User Interface / User Experience Improvement

Comments

@wpgoble
Copy link
Contributor

wpgoble commented Jan 11, 2024

A user may have all selected for Type of Seeding, but may have selected a crop or area that only has Tray or Direct Seedings. When this happens the other summary will show 0 or NaN (not a number), instead have that summary show a message: “There are no [Tray or Direct] Seedings in the options you have chosen.”

To test this go to the Seedings Report subtab under BarnKit tab, which is on the home page. Selected a date range, and try filtering different Areas and Crops.

An example is shown below:
NeedMessageTrayDirectSummaries

This issue is complete when the message appears in Tray and Direct seeding summaries, when there are no current logs in the respective summaries.


Issue by IrisSC
Friday Jul 23, 2021 at 18:33 GMT
Originally opened as DickinsonCollege/FarmData2#259

@wpgoble wpgoble added the UI/UX User Interface / User Experience Improvement label Jan 11, 2024
@wpgoble
Copy link
Contributor Author

wpgoble commented Jan 11, 2024

Also add Cypress tests that confirm this behavior.


Comment by braughtg
Wednesday Sep 01, 2021 at 13:19 GMT

@wpgoble
Copy link
Contributor Author

wpgoble commented Jan 11, 2024

Instead of a message, if there are only tray seedings or only direct seedings the other summary table should be hidden. If the results contain both tray seedings and direct seedings then both summary tables should be shown.


Comment by braughtg
Wednesday Sep 22, 2021 at 12:33 GMT

@wpgoble
Copy link
Contributor Author

wpgoble commented Jan 11, 2024

This is related to #284 and #258. A single PR that solves all three would be welcome.


Comment by braughtg
Tuesday Sep 28, 2021 at 12:16 GMT

@wpgoble
Copy link
Contributor Author

wpgoble commented Jan 11, 2024

Just for clarifications sake, you wanted me to have the summary table with no corresponding logs to show up with a message, so that the user is not confused, correct?


Comment by Batese2001
Wednesday Sep 29, 2021 at 23:10 GMT

@wpgoble
Copy link
Contributor Author

wpgoble commented Jan 11, 2024

Just for clarifications sake, you wanted me to have the summary table with no corresponding logs to show up with a message, so that the user is not confused, correct?

I think the desired behavior would be:

  • If user filters for just tray or just direct seedings then only one table appears.
  • if user filters for both, and the results contain both then both tables appear.
  • if user filters for both, and the results contain only direct or only tray (because thats what exists in the date range) then both tables appear, but the one with no records contains a message rather than 0's or NaN's.

If you have other thoughts on what might be better from a usability perspective I'm open to suggestions.


Comment by braughtg
Thursday Sep 30, 2021 at 11:56 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX User Interface / User Experience Improvement
Projects
None yet
Development

No branches or pull requests

1 participant