-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seedings Report: message in Tray/Direct Summaries #57
Comments
Also add Cypress tests that confirm this behavior. Comment by braughtg |
Instead of a message, if there are only tray seedings or only direct seedings the other summary table should be hidden. If the results contain both tray seedings and direct seedings then both summary tables should be shown. Comment by braughtg |
This is related to #284 and #258. A single PR that solves all three would be welcome. Comment by braughtg |
Just for clarifications sake, you wanted me to have the summary table with no corresponding logs to show up with a message, so that the user is not confused, correct? Comment by Batese2001 |
I think the desired behavior would be:
If you have other thoughts on what might be better from a usability perspective I'm open to suggestions. Comment by braughtg |
A user may have all selected for Type of Seeding, but may have selected a crop or area that only has Tray or Direct Seedings. When this happens the other summary will show 0 or NaN (not a number), instead have that summary show a message: “There are no [Tray or Direct] Seedings in the options you have chosen.”
To test this go to the Seedings Report subtab under BarnKit tab, which is on the home page. Selected a date range, and try filtering different Areas and Crops.
An example is shown below:
This issue is complete when the message appears in Tray and Direct seeding summaries, when there are no current logs in the respective summaries.
Issue by IrisSC
Friday Jul 23, 2021 at 18:33 GMT
Originally opened as DickinsonCollege/FarmData2#259
The text was updated successfully, but these errors were encountered: