Seeding Report Editing Issues/Bugs/Concerns

[braughtg]

Which columns in the seeding report should be editable and when?

• It seems to make sense that some columns should be editable and some may not be.
  • For example, you can edit hours but not the type of seeding.
  • When a column that needs to be changed (e.g. type of seeding) is not editable the solution is to delete the log and recreate it.
• Seems like some things should be able to be edited or deleted only under certain conditions.
  • What happens if a transplanting or harvesting log already exists that is associated with the seeding?
  • This needs to be researched. Perhaps if the planting is changed then everything will be alright?
  • Note however that the crop_tid field added to the seeding logs to make it unnecessary to fetch the plantings will also need to be updated if the crop is edited.
• When editing the location of a seeding the options should be consistent with the seeding type.
  • Only greenhouses for tray seedings and only field or bed locations for direct seedings (as in the input form)
• When editing fields that are constrained (e.g. hours or workers) the edit field should be a RegexInputComponent with an appropriate regular expression to prevent invalid inputs.

---

Issue by braughtg
Tuesday Jun 07, 2022 at 19:37 GMT
Originally opened as DickinsonCollege/FarmData2#466

[braughtg]

It seems that a separate issue should be opened to address what was discussed yesterday concerning an inflexibility of the CustomTableComponent: buttons. Every time a new button needs to be added to a table, the component shouldn't have to grow every time.

A potential discussed solution to the button problem:
We remove all the buttons currently in the CustomTableComponent (save/cancel/edit/delete) and just add a general button prop that can be added to the end of the component. This increases the flexibility of the component because it reduces the burden of adding buttons to the component and puts that responsibility back on the page which should handle those button presses. We would have to think about how one prop will account for many buttons, but I'm sure that wouldn't be too difficult.

NOTE: Addressed in Issue #530.

---

Comment by FutzMonitor
Tuesday Jul 12, 2022 at 14:49 GMT

[braughtg]

Issue #530 addresses potential updates to the CustomTableComponent that may affect a solution to this issue.

---

Comment by braughtg
Tuesday Jul 12, 2022 at 21:31 GMT

[braughtg]

I believe it would be worthwhile to consult with Matt which elements of the logs should be editable from the report table. Here are a couple of bugs concerning edits and the report table that I have witnessed.

1. Editing the row feet causes the bed feet to be recalculated. Normally this wouldn't be an issue, but it's misleading when the user changes both row feet and bed feet only for bed feet to ignore the user's input and recalculate itself. Perhaps it might be worthwhile disabling an element when one that affects its recalculation is being changed.
2. Editing the date, area, and crop all currently do not update the log in the backend.
3. Editing certain elements doesn't actually update them in the backend. This is detailed thoroughly in #544

---

Comment by FutzMonitor
Wednesday Jul 20, 2022 at 23:03 GMT