Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kDataframe PHMAP #71

Open
shokrof opened this issue Jul 8, 2020 · 4 comments
Open

kDataframe PHMAP #71

shokrof opened this issue Jul 8, 2020 · 4 comments
Assignees
@mr-eyes
Milestone
First Draft

Comments

@shokrof
Copy link
Collaborator

shokrof commented Jul 8, 2020

kDataframe PHMAP doesnt pass the test cases.
@shokrof shokrof added this to the First Draft milestone Jul 8, 2020
@mr-eyes
Copy link
Member

mr-eyes commented Jul 14, 2020

@shokrof could you please point to the issue in the code? which test case?

@shokrof
Copy link
Collaborator Author

shokrof commented Jul 14, 2020

iterate over all kmers and multi-column

@drtamermansour
Copy link
Member

multi-column !!? Is not kDataframe PHMAP still in the single column implementation stage?

@shokrof
Copy link
Collaborator Author

shokrof commented Jul 14, 2020

kDataframe MAP is working fine with multi column. PHMAP should works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mr-eyes mr-eyes

Labels
None yet
Projects
None yet
Milestone
First Draft
Development

No branches or pull requests
3 participants
@shokrof @drtamermansour @mr-eyes