Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urls should not be downcased #33

Open
maia opened this issue Feb 28, 2016 · 1 comment
Open

urls should not be downcased #33

maia opened this issue Feb 28, 2016 · 1 comment

Comments

@maia
Copy link
Collaborator

maia commented Feb 28, 2016

While it's rare that a URL uses uppercase letters, some do. And as urls are case-sensitive, they should not be transformed when using the option downcase: true, so the following is not desired:

> PragmaticTokenizer::Tokenizer.new(downcase: true).tokenize("http://test.com/UPPERCASE")
=> ["http://test.com/uppercase"]
@maia maia added the bug label Feb 28, 2016
@diasks2
Copy link
Owner

diasks2 commented Mar 2, 2016

I added a spec for this (f2198d6). This is a tough one. I can't think of a good way to do it without taking a big performance hit. If you have any ideas let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants