-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to declare themes, modes and workers within ember-engines #10
Comments
I would expect the standard pattern for configuring an engine to work, something like: module.exports = EngineAddon.extend({
ace: {
// ember-ace config here
}
}); If it doesn't, that's likely a bug (either here or in ember-engines) |
I tried to declare the settings exactly like this. |
Is your engine lazy or eager? It's possible you're hitting ember-engines/ember-engines#386 |
We are also running into an error after moving our code that uses ember-ace from a dedicated admin app to a lazy engine in our main app. Here's how the engine's index configures ember-ace:
When I run My expectation is that the ace.js file would be in-lined into the egine-vendor.js the way that it is inlined into an app's vendor.js. I followed the above link to the ember-engines issue, and it's not obvious to me what, if any, additional actions I would need to take in order to ensure that the ace code is in-lined into my lazy engine-vendor.js. That issue (like this one) is a couple years old, and we're on the latest ember-engines (0.8.2) and and ember-ace (2.0.1), so I don't know if the proposed (and seemingly hacky) fixes are still needed. Am I missing something? |
I am currently moving the admin interface from the main application into an ember-engine. So far i am unable to import or declare the ember-ace settings.
Any suggestions?
The text was updated successfully, but these errors were encountered: