You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we have two functions with the same signature (example: initializePlayer in DFCore and initializePlayer in DFArena), we can't build the Diamond ABI due to the overlapping function check (strict = true).
If we have two functions with the same name but different types, we have a problem with ethers where need to fetch the functions with await sampleContractEthers["overloading()"](); , which breaks most existing calls and tests that expect the standard sampleContractEthers.overloading() getter.
The problems we have identified:
If we have two functions with the same signature (example: initializePlayer in DFCore and initializePlayer in DFArena), we can't build the Diamond ABI due to the overlapping function check (strict = true).
If we have two functions with the same name but different types, we have a problem with ethers where need to fetch the functions with
await sampleContractEthers["overloading()"]();
, which breaks most existing calls and tests that expect the standardsampleContractEthers.overloading()
getter.See #3 for proposed temporary solution.
The text was updated successfully, but these errors were encountered: