Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate valid ABI and Typechain for anticipated Diamond Cut #4

Open
cha0sg0d opened this issue Mar 28, 2022 · 0 comments
Open

Generate valid ABI and Typechain for anticipated Diamond Cut #4

cha0sg0d opened this issue Mar 28, 2022 · 0 comments

Comments

@cha0sg0d
Copy link

cha0sg0d commented Mar 28, 2022

The problems we have identified:

  1. If we have two functions with the same signature (example: initializePlayer in DFCore and initializePlayer in DFArena), we can't build the Diamond ABI due to the overlapping function check (strict = true).

  2. If we have two functions with the same name but different types, we have a problem with ethers where need to fetch the functions with await sampleContractEthers["overloading()"](); , which breaks most existing calls and tests that expect the standard sampleContractEthers.overloading() getter.

See #3 for proposed temporary solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant