Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: error handlings on 400-599 responses and error on resizing of app detail terminal #4710

Open
2 tasks done
Elessar1802 opened this issue Feb 22, 2024 · 4 comments · May be fixed by devtron-labs/dashboard#1642
Open
2 tasks done
Assignees
Labels
bug Something isn't working potential-duplicate

Comments

@Elessar1802
Copy link

Elessar1802 commented Feb 22, 2024

📜 Description

An optional check is required since upon failure of the preceding api calls can return response objects without the result property field.

Users will get TypeError: Cannot read properties of undefined (reading 'isLockConfigError')

Additionally need to add missing catch blocks to api calls that can throw errors. Unhandled errors can cause the page to crash. Once added the user will be notified of the issues and the page won't fully break.

Resizing the window while app details terminal is in view will throw errors - ResizeObserver loop finished with undelivered notifications.

👟 Reproduction steps

If the while saving the deployment template the fetch api calls fail we will get a TypeError.

Resize the browser window with app details terminal open.

👍 Expected behavior

No TypeError (No crash)

👎 Actual Behavior

TypeError (crash) and a ticket on sentry

☸ Kubernetes version

NaN

Cloud provider

NaN

🌍 Browser

Chrome

🧱 Your Environment

Chrome: 120.0 Linux

✅ Proposed Solution

Add an optional chaining check

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

AB#8668

@systemsdt
Copy link
Contributor

Potential duplicates:

2 similar comments
@systemsdt
Copy link
Contributor

Potential duplicates:

@systemsdt
Copy link
Contributor

Potential duplicates:

@systemsdt
Copy link
Contributor

Potential duplicates:

@Elessar1802 Elessar1802 changed the title Bug: Error Handling in Deployment Template Bug: error handlings on 400-599 responses and error on resizing of app detail terminal Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working potential-duplicate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants