Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: refactor all sub's to occur in createEffect signals and add proper cleanups #62

Open
skeptrunedev opened this issue Mar 4, 2023 · 0 comments
Open

bugfix: refactor all sub's to occur in createEffect signals and add proper cleanups #62

skeptrunedev opened this issue Mar 4, 2023 · 0 comments
Labels
bug Something isn't working refactor

Comments

@skeptrunedev
Copy link
Contributor

skeptrunedev commented Mar 4, 2023 •
edited
Loading

This requires changing all of the sub's to occur in createEffect signals such that they can have proper unsub cleanups.
@skeptrunedev skeptrunedev added the bug Something isn't working label Mar 4, 2023
@skeptrunedev skeptrunedev changed the title bugfix: subscriptions just need an overhaul so we don't ever double subscribe and properly close connections bugfix: refactor all sub's to occur in createEffect signals Mar 6, 2023
@skeptrunedev skeptrunedev changed the title bugfix: refactor all sub's to occur in createEffect signals bugfix: refactor all sub's to occur in createEffect signals and add proper cleanups Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skeptrunedev