Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tipg Features fails OGC validation #84

Open
vincentsarago opened this issue Jun 30, 2023 · 1 comment
Open

tipg Features fails OGC validation #84

vincentsarago opened this issue Jun 30, 2023 · 1 comment
Labels
wontfix This will not be worked on

Comments

@vincentsarago
Copy link
Member

vincentsarago commented Jun 30, 2023

using https://cite.opengeospatial.org/teamengine/ with a demo endpoint (https://vector.eoapi.dev)

I'm getting a bunch of error or skipped tests

Screenshot 2023-06-30 at 10 10 29 PM

error 👇
Screenshot 2023-06-30 at 10 11 27 PM

Note: my STAC API returns the same error 🤷

Other issues (skipped) because apparently we are missing some conformance classes 🤷

Screenshot 2023-06-30 at 10 15 43 PM

apparently we should have way more conformance like 👇

http://www.opengis.net/spec/cql2/0.0/conf/advanced-comparison-operators
http://www.opengis.net/spec/cql2/0.0/conf/array-operators
http://www.opengis.net/spec/cql2/0.0/conf/basic-cql2
http://www.opengis.net/spec/cql2/0.0/conf/basic-spatial-operators
http://www.opengis.net/spec/cql2/0.0/conf/case-insensitive-comparison
http://www.opengis.net/spec/cql2/0.0/conf/cql2-json
http://www.opengis.net/spec/cql2/0.0/conf/cql2-text
http://www.opengis.net/spec/cql2/0.0/conf/property-property
http://www.opengis.net/spec/cql2/0.0/conf/spatial-operators
http://www.opengis.net/spec/cql2/0.0/conf/temporal-operators
http://www.opengis.net/spec/ogcapi-common-1/1.0/conf/core
http://www.opengis.net/spec/ogcapi-common-1/1.0/conf/html
http://www.opengis.net/spec/ogcapi-common-1/1.0/conf/json
http://www.opengis.net/spec/ogcapi-common-1/1.0/conf/oas30
http://www.opengis.net/spec/ogcapi-common-2/0.0/conf/collections
http://www.opengis.net/spec/ogcapi-common-2/0.0/conf/html
http://www.opengis.net/spec/ogcapi-common-2/0.0/conf/json
http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/core
http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/geojson
http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/html
http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/oas30
http://www.opengis.net/spec/ogcapi-features-2/1.0/conf/crs
http://www.opengis.net/spec/ogcapi-features-3/0.0/conf/features-filter
http://www.opengis.net/spec/ogcapi-features-3/0.0/conf/filter
http://www.opengis.net/spec/ogcapi-features-3/0.0/conf/queryables
http://www.opengis.net/spec/ogcapi-features-3/0.0/conf/queryables-query-parameters
http://www.opengis.net/spec/ogcapi-features-4/0.0/conf/create-replace-delete
http://www.opengis.net/spec/ogcapi-features-4/0.0/conf/features
http://www.opengis.net/spec/ogcapi-features-4/0.0/conf/optimistic-locking
http://www.opengis.net/spec/ogcapi-features-4/0.0/conf/update
http://www.opengis.net/spec/ogcapi-styles-1/0.0/conf/core
http://www.opengis.net/spec/ogcapi-styles-1/0.0/conf/manage-styles
http://www.opengis.net/spec/ogcapi-styles-1/0.0/conf/mapbox-styles
http://www.opengis.net/spec/ogcapi-styles-1/0.0/conf/sld-10
http://www.opengis.net/spec/ogcapi-tiles-1/1.0/conf/collection-selection
http://www.opengis.net/spec/ogcapi-tiles-1/1.0/conf/core
http://www.opengis.net/spec/ogcapi-tiles-1/1.0/conf/dataset-tilesets
http://www.opengis.net/spec/ogcapi-tiles-1/1.0/conf/datetime
http://www.opengis.net/spec/ogcapi-tiles-1/1.0/conf/geodata-tilesets
http://www.opengis.net/spec/ogcapi-tiles-1/1.0/conf/mvt
http://www.opengis.net/spec/ogcapi-tiles-1/1.0/conf/tileset
http://www.opengis.net/spec/ogcapi-tiles-1/1.0/conf/tilesets-list
http://www.opengis.net/spec/tms/2.0/conf/json-tilematrixset
http://www.opengis.net/spec/tms/2.0/conf/json-tilematrixsetlimits
http://www.opengis.net/spec/tms/2.0/conf/json-tilesetmetadata
http://www.opengis.net/spec/tms/2.0/conf/tilematrixset
http://www.opengis.net/spec/tms/2.0/conf/tilematrixsetlimits
http://www.opengis.net/spec/tms/2.0/conf/tilesetmetadata

ref https://demo.ldproxy.net/daraa/conformance 😅

@vincentsarago
Copy link
Member Author

vincentsarago commented Jul 2, 2023

After digging more on this I'm giving up. The first issue seems to be that the openapi documentation created by FastAPI is not valid for https://github.com/opengeospatial/ets-ogcapi-features10/blob/68601b530be4a0765a50f445444e80b9a8094d27/src/main/java/org/opengis/cite/ogcapifeatures10/conformance/core/apidefinition/ApiDefinition.java#L59-L66

Then because this tests fail, all the other tests will be skipped. I'm going to put this issue as WontFix because I think it's either an issue on the test suite or in FastAPI but not in TiPG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant