Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search as URL parameter #464

Open
Malix-Labs opened this issue Sep 16, 2024 · 4 comments · May be fixed by #476
Open

Search as URL parameter #464

Malix-Labs opened this issue Sep 16, 2024 · 4 comments · May be fixed by #476

Comments

@Malix-Labs
Copy link

Malix-Labs commented Sep 16, 2024 •
edited
Loading

Search as URL parameter (for https://containers.dev/features and https://containers.dev/templates)
@bamurtaugh
Copy link
Member

Hi there! Could you expand a bit on what you're interested in? Additionally, we'd certainly welcome a PR contributing the change(s) you have in mind!

@Malix-Labs
Copy link
Author

Malix-Labs commented Sep 28, 2024 •
edited
Loading

I am on phone right now, sorry for the mobile PC emulation screenshot

For example, the link https://containers.dev/features?search=test will directly open this page with the "test" search parameter :

Screenshot_20240928-095418~2

This is known as "URL parameter"

@bamurtaugh
Copy link
Member

Thanks for clarifying! I think that change makes sense! If you'd be willing to contribute a PR, we'd absolutely welcome it 😄

@Malix-Labs Malix-Labs linked a pull request Oct 1, 2024 that will close this issue
Draft
4 tasks
@Malix-Labs
Copy link
Author

@bamurtaugh done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: search as URL parameter Malix-Labs/devcontainers.github.io
2 participants
@bamurtaugh @Malix-Labs