From c47808477807bab5a96bf1e6c8313a9694c422ac Mon Sep 17 00:00:00 2001 From: Josh Spicer Date: Tue, 29 Oct 2024 18:54:01 -0700 Subject: [PATCH 1/2] Remove unnecessary log A shown in https://github.com/devcontainers/spec/discussions/513, this log message is not relevant and masking the true error printed just before. --- src/spec-node/templatesCLI/publish.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/spec-node/templatesCLI/publish.ts b/src/spec-node/templatesCLI/publish.ts index be70660b1..662f7a606 100644 --- a/src/spec-node/templatesCLI/publish.ts +++ b/src/spec-node/templatesCLI/publish.ts @@ -67,7 +67,6 @@ async function templatesPublish({ const metadata = await packageTemplates(packageArgs); if (!metadata) { - output.write(`(!) ERR: Failed to fetch ${OCICollectionFileName}`, LogLevel.Error); process.exit(1); } From 26fc33f507853cdb167e718913e3fbbf29ccb6fa Mon Sep 17 00:00:00 2001 From: Josh Spicer Date: Tue, 29 Oct 2024 18:57:02 -0700 Subject: [PATCH 2/2] remove unused import --- src/spec-node/templatesCLI/publish.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spec-node/templatesCLI/publish.ts b/src/spec-node/templatesCLI/publish.ts index 662f7a606..cff9bb1f0 100644 --- a/src/spec-node/templatesCLI/publish.ts +++ b/src/spec-node/templatesCLI/publish.ts @@ -10,7 +10,7 @@ import { publishOptions } from '../collectionCommonUtils/publish'; import { getCLIHost } from '../../spec-common/cliHost'; import { loadNativeModule } from '../../spec-common/commonUtils'; import { PackageCommandInput } from '../collectionCommonUtils/package'; -import { getArchiveName, OCICollectionFileName } from '../collectionCommonUtils/packageCommandImpl'; +import { getArchiveName } from '../collectionCommonUtils/packageCommandImpl'; import { packageTemplates } from './packageImpl'; import { getCollectionRef, getRef, OCICollectionRef } from '../../spec-configuration/containerCollectionsOCI'; import { doPublishCommand, doPublishMetadata } from '../collectionCommonUtils/publishCommandImpl';