-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"devcontainer features publish" fails to log in with Artifactory #691
Comments
imphil
added a commit
to imphil/cli
that referenced
this issue
Nov 22, 2023
To authenticate against an OCI registry the code currently requires a `scope` attribute in the `WWW-Authenticate` header. This key is optional according to RFC 6750 [1], an empty string can be used if it's not present. Artifactory does not include the `scope` attribute and hence authentication fails currently. Fix that by making the attribute optional. [1] "Use of the "scope" attribute is OPTIONAL." Fixes devcontainers#691
With #692 I'm able to successfully push a feature to Artifactory. |
Thank you for reporting the issue and the quick fix, left a review comment. |
imphil
added a commit
to imphil/cli
that referenced
this issue
Nov 27, 2023
To authenticate against an OCI registry the code currently requires a `scope` attribute in the `WWW-Authenticate` header. This key is optional according to RFC 6750 [1], an empty string can be used if it's not present. Artifactory does not include the `scope` attribute and hence authentication fails currently. Fix that by making the attribute optional. [1] "Use of the "scope" attribute is OPTIONAL." Fixes devcontainers#691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're using Artifactory as container registry and I'm trying to use it to store a Dev Container Feature. Unfortunately, the login fails.
I have setup a Docker credential helper to return the username and token, but we're not even getting there:
The
scope
key is not part of the response, which seems to be allowed according to https://datatracker.ietf.org/doc/html/rfc6750#section-3 (as referenced in https://distribution.github.io/distribution/spec/auth/token/).I'm not even close to understanding how the auth flow works, so I'd appreciate further input on that.
Container Registry: Artifactory Enterprise Plus 7.55.8 rev 75508900
The text was updated successfully, but these errors were encountered: