We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's a bit inadequate to search docker container only with project name and services when project name is the basename of the working directory.
cli/src/spec-node/dockerCompose.ts
Line 613 in 71180e7
Can I suggest to either use longer name for project:
Lines 643 to 645 in 71180e7
like replace the use of basename with a representation of the full path where each subdirectory is connected with an underscore (_)
function pathToUnderscore(p: string): string { return p.split(path.sep).join('_'); } ... ... if (equalPaths(cliHost.platform, workingDir, cliHost.path.join(configDir, '.devcontainer'))) { return toProjectName(`${pathToUnderscore(configDir)}_devcontainer`, newProjectName); } return toProjectName(pathToUnderscore(workingDir), newProjectName);
The text was updated successfully, but these errors were encountered:
Hi 👋
Thanks for the suggestion, it makes sense to me.
@NerdToMars would you be interested in contributing the change to the CLI? We appreciate support from the community, thanks!
Sorry, something went wrong.
or is it possible to add more filter in findComposeContainer function
findComposeContainer
like filter based on devcontainer.local_folder
No branches or pull requests
It's a bit inadequate to search docker container only with project name and services when project name is the basename of the working directory.
cli/src/spec-node/dockerCompose.ts
Line 613 in 71180e7
Can I suggest to either use longer name for project:
cli/src/spec-node/dockerCompose.ts
Lines 643 to 645 in 71180e7
like replace the use of basename with a representation of the full path where each subdirectory is connected with an underscore (_)
The text was updated successfully, but these errors were encountered: