Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom line separators #54

Open
dfranco opened this issue Aug 13, 2024 · 4 comments
Open

Custom line separators #54

dfranco opened this issue Aug 13, 2024 · 4 comments

Comments

@dfranco
Copy link

dfranco commented Aug 13, 2024

Hi @derlin ,

it would be nice to have another cli parameter to customise the line separators.

Actually, the default line separator character is CRLF so \r\n

Unless I missed it, this option does not seem to exist yet.

Thanks for the great tool by the way!

Best,

@derlin
Copy link
Owner

derlin commented Aug 13, 2024

Hello you, long time no see :)

Indeed, the line separator is currently hard-coded. However, it is \n and not \r\n... What do you mean by

the default line separator character is CRLF so \r\n

I am wondering though: is it better to provide an option, or to try to detect the line separator from the text/doc itself?

@dfranco
Copy link
Author

dfranco commented Aug 14, 2024

Hi there, indeed, long time no see :)

Hello you, long time no see :)

Indeed, the line separator is currently hard-coded. However, it is \n and not \r\n... What do you mean by

the default line separator character is CRLF so \r\n

That's not what my IDE tells me :)

I am wondering though: is it better to provide an option, or to try to detect the line separator from the text/doc itself?

An extra parameter would be nice, including an "auto detect " one

Best,

@derlin
Copy link
Owner

derlin commented Sep 11, 2024

Hello @dfranco , I am definitely not able to reproduce the issue, you'll have to show me.

@dfranco
Copy link
Author

dfranco commented Sep 12, 2024

Hello @dfranco , I am definitely not able to reproduce the issue, you'll have to show me.

Let's plan a call so I can show you

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants