Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map generation is sub-optimal #19

Open
andrewrk opened this issue Dec 31, 2012 · 2 comments
Open

map generation is sub-optimal #19

andrewrk opened this issue Dec 31, 2012 · 2 comments

Comments

@andrewrk
Copy link
Contributor

node v0.8.16, fresh jsmc checkout + npm install.

node server.example.js config.default.json

No output, server hangs, ctrl+C does nothing, server is not online.

@deoxxa
Copy link
Owner

deoxxa commented Dec 31, 2012

Yeah, that's it generating the map. On the first run, or after the world is deleted, it'll sit there for a good minute or so depending on the hardware. The ctrl+c thing, I think, is because of the server-stop plugin.

I guess there's two problems:

  1. Map generation can block the entire server, not just for the duration of one chunk being generated (which is just a huge amount of CPU time, not much can be done there), but for the entire duration apparently.
  2. The server-stop plugin doesn't remove its handler on the first SIGINT.

The server-stop plugin should be easy enough to fix. The map generation resource usage is not fixable, but perhaps can be reworked (as separate process perhaps) to not block the server.

@andrewrk
Copy link
Contributor Author

Ah, thanks for the explanation. I'll rename the issue and leave it open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants