Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Data URL entrypoints #333

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix: Data URL entrypoints #333

wants to merge 4 commits into from

Conversation

arnauorriols
Copy link
Member

@arnauorriols arnauorriols commented Oct 17, 2024 •
edited
Loading

Fixes #331

magurotuna
magurotuna approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good, but the CI is blocking us because of #328.
I am trying to fix this issue in #332 but this is also blocked by another factor, i.e. we need to wait until deno_emit supports JSR specifier: denoland/deno_emit#167. I believe this can be solved with denoland/deno_cache_dir#64

@magurotuna
Copy link
Member

FYI #332 should make this PR's CI green too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magurotuna magurotuna magurotuna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support data URL entrypoints
2 participants
@arnauorriols @magurotuna