fix(deploy): ensure import map or config file is included in the manifest #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a check before uploading assets if an import map specified in
--import-map
option or a config file (e.g.deno.json
) is included in the manifest. This will help users understand why import maps don't get applied during deployment.case 1: import map not included
If the specified import map is not included in the manifest due to
--include
and/or--exclude
settings, this is a config conflict and most likely a wrong setup. So in this case, deployctl will error out with a specific error message:case 2: deno.json not included
In this case, we can't necessarily say that this is a wrong setup, because deployctl usually infers the config file location and the config file may not have
imports
property. So instead of immediately erroring out, it shows a warning message that tells users that any import map settings in the config file won't be used:Closes #324