Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not implemented: ChildProcess.prototype.disconnect #22503

Closed
birkskyum opened this issue Feb 20, 2024 · 4 comments
Closed

Not implemented: ChildProcess.prototype.disconnect #22503

birkskyum opened this issue Feb 20, 2024 · 4 comments

Comments

@birkskyum
Copy link
Contributor

Version: Deno 1.40.5

Repro:

 deno run -A npm:create-remix@latest --template remix-run/remix/templates/vite         

 remix   v2.4.0 💿 Let's build a better website...

   dir   Where should we create your new project?
         ./new-remix-4

      ◼  Template: Using remix-run/remix/templates/vite...
      ✔  Template copied

   git   Initialize a new git repository?
         Yes

  deps   Install dependencies with npm?
         Yes

Warning: Not implemented: ChildProcess.prototype.disconnect

After the Install dependencies with npm? it'll hang, because it can't disconnect, and when I interrupt it with ctrl-c, then it'll prompt the warning.

@birkskyum
Copy link
Contributor Author

@birkskyum birkskyum closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2024
@bartlomieju
Copy link
Member

I believe this was fixed in 8fdd655

@birkskyum
Copy link
Contributor Author

birkskyum commented Feb 20, 2024

Fantastic! I'll validate when the next patch is out. Prisma, Qwik, Remix etc.

@bartlomieju
Copy link
Member

@birkskyum you should be able to do it already using deno upgrade --canary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants