Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure only things that need to be boxed are boxed #45

Open
Tracked by #42
dansteren opened this issue Mar 13, 2023 · 0 comments
Open
Tracked by #42

Make sure only things that need to be boxed are boxed #45

dansteren opened this issue Mar 13, 2023 · 0 comments
Labels
code cleanliness Product health, tech debt, etc.

Comments

@dansteren
Copy link
Contributor

dansteren commented Mar 13, 2023

Right now we box everything. Rather than just bulk boxing everyting (whether it needs it or not) we should only box things that will cause recursive problems (and actually need to be boxed). So it involves evaluating each box and removing the ones that aren't necessary.

Currently the boxing only happens inside of tuples, records, and variants. Here's where you'd want to look for this code:

  • cdk_framework/src/act/node/candid/record/member.rs:17
  • cdk_framework/src/act/node/candid/tuple/elem.rs:26
  • cdk_framework/src/act/node/candid/variant/member:33
@dansteren dansteren mentioned this issue Mar 13, 2023
9 tasks
@dansteren dansteren added the code cleanliness Product health, tech debt, etc. label Jun 5, 2023
@bdemann bdemann removed their assignment Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanliness Product health, tech debt, etc.
Projects
None yet
Development

No branches or pull requests

2 participants