Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about an embed for Rumble? #70

Open
brentarias opened this issue Oct 28, 2023 · 4 comments
Open

How about an embed for Rumble? #70

brentarias opened this issue Oct 28, 2023 · 4 comments
Labels
help wanted Extra attention is needed new service Issues and PRs for adding new embed providers

Comments

@brentarias
Copy link

Rumble is the biggest competitor for Youtube.

@delucis delucis added enhancement Improvement or extension of current features help wanted Extra attention is needed labels Oct 28, 2023
@delucis
Copy link
Owner

delucis commented Oct 28, 2023

I haven’t heard of Rumble, but if there’s a good way to build an embed component a PR would be welcome.

We have a guide for how to add a new component that should be helpful. Happy to answer questions if things aren’t clear.

@delucis delucis added new service Issues and PRs for adding new embed providers and removed enhancement Improvement or extension of current features labels Apr 4, 2024
@nathanchere
Copy link

Programmatic Rumble embedding is unfortunately not as straight-forward as Youtube embedding. I've started on this though, I can't imagine it will take more than a few more days to have something to push.

@nathanchere
Copy link

I have a working example but can't get it working in astro-embed because of the typescript restrictions clashing with a 'rumble-core' package. I now remember one of the reasons why I always hated typescript so much.

@delucis
Copy link
Owner

delucis commented May 15, 2024

I have a working example but can't get it working in astro-embed

Feel free to open a draft PR and I’ll try to see if I can help out when I have time — thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed new service Issues and PRs for adding new embed providers
Projects
None yet
Development

No branches or pull requests

3 participants