-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users aren't notified that their account is running out #21
Comments
The bot account should be created during
|
There is another solution for this which doesn't necessarily involve user warnings - soft-expiry: If the current prune function would only delete users which have not logged in in the past... while, active user accounts wouldn't be deleted. It's a relatively simple fix which makes sense in the short term. Admins would still be happy because they don't have a load of inactive user accounts to maintain. Sensible limits could be: only expire accounts if last_login is 2 months ago, or 20% of the account's TTL (time to live when account was created) or so. There might be a limit to soft-expiry, e.g. double the original TTL - accounts would be hard-expired if they reach this limit. IMHO we should only do this in combination with expiry warnings, as it would mean deleting the accounts of provably active users. It might make sense to hard-expire accounts with a TTL of less than a week. There are use cases where you would want accounts to be really really deleted. If we go for soft-expiry it needs to be documented for admins. |
Showing the expiration time in the DC app would also be interesting. Either the app could remember the expiration time upon account creation, when mailadm tells it to the DC app, or the mailcow server could inject a header which tells the app about the expiration time. This of course requires changes to the DC app and/or the server. |
For expiry warnings, there should be a template with the text of the warning, which admins can edit; it would be nice to offer more languages than just english / give admins the chance to modify the warning template with their own text. Or might it be possible to localize the warning with the language of the user? If it was localized/shown in the app this would be easy. Another option would be getting some language settings information from mailcow and localizing it inside mailadm. |
@adbenitez suggested: "No UI needed, core should store [the account TTL] and warn with a device message on login and maybe a remainder the day before expiration or when it expired" (I like it because that makes it much easier to localize) |
The remainder message should be imho earlier than 1 day before expiration. IMHO at least 7 days but ideally 35-60 days. From my experience of using DC with multiple accounts I can tell I leave some accounts unintentionally unchecked for a month or so 😢 - but perhaps if DC offered simultaneous "merged" account UX, these 35-60 days could be shortened to those 7 days. |
tl;dr: we now don't expire active accounts, if they are created with tokens with at least 28 days expiry.
Yet to do:
Uhm, this is probably a feature request. But I take the liberty. har har.
The text was updated successfully, but these errors were encountered: