Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeltaChat fails to Display a Headline and an URL/URI (removes underscores). That breask a click on the URL #3275

Closed
winspool opened this issue Jun 18, 2023 · 3 comments
Labels
bug Something isn't working experimental feature

Comments

@winspool
Copy link

  • Operating System (Linux/Mac/Windows/iOS/Android): X86-64-linux
  • Delta Chat Version: 1.36.4 and 1.37.1
  • Expected behavior:
    • An URL, which i send must not be changed, when displayed:
    • An underscore in an URL/URI is never a marker for italic text
  • Actual behavior:
    • The Display of a Headline and an URL in a post is changed in the Desktop App.
    • Receiving in DeltaChat 1.36.5-Android is correct.
    • Sending the same Mail from the Android App is correctly displayed in the Android App,
      but the Display in the Desktop App is also broken.
  • Steps to reproduce the problem:
  • I want to send:
AM_CONDITIONAL

https://www.gnu.org/software/automake/manual/html_node/Usage-of-Conditionals.html
  • Screenshots:

    • 3 Messages send with 1.36.4, last message send with 1.37.1
      grafik
  • Logs:

@Simon-Laux
Copy link
Member

Simon-Laux commented Jun 18, 2023

turn off markdown, it is experimental for a reason, but thanks for reporting anyway.

Still strange, isn't it the same link in all 4 messages? Ah it's from the text above...

we should probably just remove _ from our markdown flavour: deltachat/message-parser#23

@Simon-Laux Simon-Laux added bug Something isn't working experimental feature labels Jun 18, 2023
@winspool
Copy link
Author

winspool commented Jun 18, 2023

turn off markdown, it is experimental for a reason, but thanks for reporting anyway.

Thanks, Deactivated. Display is now correct.
Didn't remember, that is was active

Still strange, isn't it the same link in all 4 messages? Ah it's from the text above...

  • 1: As i needed it -> broken
  • 2: Tried with quotation marks -> broken
  • 3: Straight link, to remember it -> works
  • -: Updated App from 1.36.4 to 1.37.1
  • 4: Tried again with 1.37.1 -> broken
  • 5: (after the screenshoot): Sending the text from the Android app -> broken

we should probably just remove _ from our markdown flavour: deltachat/message-parser#23

That's probably the best fix.

Allow an underscore as italic marker only at the start/end of a word or
ignoring an underscore, when the world is "All Uppercase"
would still fail, when sending a text like this: STDC_VERSION >= 202311L
(Even github markdown kills the underscores hereand outputs "STDC_VERSION" in bold)

__STDC_VERSION__  >= 202311L

Ignoring an underscore in an URL would at least avoid breaking an URL.

@winspool winspool changed the title DeltaChat Fails to Display a Headline and an URL/URI (removes underscores). That breask a click on the URL DeltaChat fails to Display a Headline and an URL/URI (removes underscores). That breask a click on the URL Jun 18, 2023
@Simon-Laux
Copy link
Member

it is tracked and discussed in deltachat/message-parser#23, I closed it here, if you come across this issue please comment over there and disable the experimental markdown feature as a quick fix.

@Simon-Laux Simon-Laux closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working experimental feature
Projects
None yet
Development

No branches or pull requests

2 participants