Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify internal visibility by replacing conditional flags with pub(crate) prefixes #672

Open
sebastiantia opened this issue Jan 31, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sebastiantia
Copy link
Collaborator

we can define the default visibility of delta internals by prefixing the struct/fn/... with pub(crate) instead of #[cfg_attr(not(feature = "developer-visibility"), visibility::make(pub(crate)))]. This simplifies the codebase.

Examples:

#[cfg_attr(not(feature = "developer-visibility"), visibility::make(pub(crate)))]

#[cfg_attr(not(feature = "developer-visibility"), visibility::make(pub(crate)))]

and many more...

@sebastiantia sebastiantia added enhancement New feature or request good first issue Good for newcomers labels Jan 31, 2025
@sebastiantia sebastiantia changed the title Replace #[cfg_attr(not(feature = "developer-visibility"), visibility::make(pub(crate)))] with pub(crate)s simplify internal visibility by replacing conditional flags with pub(crate) prefixes Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant