Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"decryptResourceInternal" method visibility public #503

Open
kronthto opened this issue Apr 19, 2023 · 1 comment
Open

"decryptResourceInternal" method visibility public #503

kronthto opened this issue Apr 19, 2023 · 1 comment
Labels

Comments

@kronthto
Copy link

kronthto commented Apr 19, 2023

I was wondering, why is this public/exposed, all the other "Internal" methods appear to be private. I couldn't find external references to it. Just an oversight?

public static function decryptResourceInternal($inputHandle, $outputHandle, KeyOrPassword $secret)

It's not a big problem though, and changing this risks breaking integrations in the wild that are using it directly now.

@defuse
Copy link
Owner

defuse commented Apr 20, 2023

Good point, it indeed should have been private. Thanks!

@defuse defuse added the v3.0 label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants