Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JAX backend handling for consistency across the codebase #4308

Open
coderabbitai bot opened this issue Nov 4, 2024 · 0 comments
Open

Update JAX backend handling for consistency across the codebase #4308

coderabbitai bot opened this issue Nov 4, 2024 · 0 comments
Assignees
@njzjz
Labels
enhancement

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2024

The addition of JAX to the DPBackend enum requires updates in multiple files to maintain consistency across the codebase:

  • source/api_cc/src/DeepTensor.cc: Backend type checks need JAX handling
  • source/api_cc/src/DeepPot.cc: Missing JAX case in backend comparisons
  • source/api_cc/src/DataModifier.cc: Backend switch statements need JAX support

This issue was identified in PR #4307 (link) during the code review discussion here.

cc @njzjz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njzjz njzjz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@njzjz