Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Old implemetation of pytorch models need to be removed #3913

Closed
iProzd opened this issue Jun 26, 2024 · 0 comments · Fixed by #4223
Closed

[Feature Request] Old implemetation of pytorch models need to be removed #3913

iProzd opened this issue Jun 26, 2024 · 0 comments · Fixed by #4223
Assignees
@iProzd
Labels
enhancement
Milestone
v3.0.0

Comments

@iProzd
Copy link
Collaborator

iProzd commented Jun 26, 2024

Summary

Old implemetation of pytorch models need to be removed.

Detailed Description

See above.

Further Information, Files, and Links

See above.
@iProzd iProzd self-assigned this Sep 26, 2024
@njzjz njzjz added this to the v3.0.0 milestone Sep 26, 2024
@iProzd iProzd mentioned this issue Oct 16, 2024
Merged
@iProzd iProzd linked a pull request Oct 16, 2024 that will close this issue
Chore(pt):rm old pt implementation #4223
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 17, 2024
@iProzd @pre-commit-ci
Chore(pt):rm old pt implementation (#4223)
2871fec 
Fix #3913.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced `exclude_types` parameter in `DipoleFittingNet` and
`PolarFittingNet` constructors for improved flexibility.
  - Added `SimpleLinear` class to enhance network functionality.

- **Bug Fixes**
- Removed `old_impl` parameter across various classes, streamlining
interfaces and ensuring consistent behavior.

- **Documentation**
- Updated test cases to reflect the removal of `old_impl`, focusing on
new implementations.

- **Chores**
- Deleted obsolete files and classes to simplify the codebase and
improve maintainability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@njzjz njzjz closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iProzd iProzd

Labels
enhancement
Projects
DeePMD-kit V3.0.0 RC
Status: Done
Multiple backend support for DeePMD-kit
Archived in project
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Chore(pt):rm old pt implementation iProzd/deepmd-kit
2 participants
@njzjz @iProzd